-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
if a message gets more than 5 of any reaction, not just stars, it will now be added to the starboard #191
base: main
Are you sure you want to change the base?
Conversation
any reaction emoji can put something on the starboard, not just stars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs more opinions.
personally starboards is intentionally for keeping the amount of star reactions on a message then post it on starboard channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the entire purpose of starboard is keeping track of star reactions on message and NOT any reactions
Is this tested? Looks like this would add it to the board for ANY combinations of 5+ reactions, ideally they would be 5+ of the same reaction |
We discussed this in the discord, we thought it be better to have it more general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a bug which I have fixed here:
oh-finks#1
fixed bug where non-star reactions get ignored
ah okay |
I think i still need to be convinced |
take it up with virbox himself |
What kind of change does this PR introduce?
(Bug fix, feature, docs update, ...)
Describe the changes proposed in the pull request
A quick description of the changes made to the repository
What is the current behavior?
(You can also link to an open issue here)
What is the new behavior
(if this is a feature change)?
Does this PR introduce a breaking change?
(What changes might users need to make in their application due to this PR?)
Does this PR introduce changes to the database?
(What has changed? Did you make sure to setup the create statements in
__main__.py
?)Other information: